services/horizon/internal/ingest/processors: Ingest new invoke host operation type #5488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
reviewed
Oct 8, 2024
services/horizon/internal/integration/testdata/soroban_constructor_contract.wasm
Outdated
Show resolved
Hide resolved
services/horizon/internal/integration/invokehostfunction_test.go
Outdated
Show resolved
Hide resolved
services/horizon/internal/ingest/processors/operations_processor.go
Outdated
Show resolved
Hide resolved
sreuland
reviewed
Oct 8, 2024
services/horizon/internal/integration/contracts/constructor/src/lib.rs
Outdated
Show resolved
Hide resolved
|
@Shaptic can you take another look? I think all code review feedback has been addressed |
tamirms
force-pushed
the
protocol-22
branch
2 times, most recently
from
62974c6 to
443fa19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
CHANGELOG.mdwithin the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Fixes #5437
Update Horizon ingestion and tests to support creating a contract with a constructor.
The test case included in this PR covers invoking a constructor which has multiple arguments, requires auth, and performs asset balance changes.
Known limitations
[N/A]